Comments on: Creating a Table of Contents Generator in PHP http://www.webdesignlessons.com/creating-a-table-of-contents-generator-in-php/ Fri, 03 Feb 2012 12:32:32 +0000 hourly 1 http://wordpress.org/?v=3.3.1 By: Nathan http://www.webdesignlessons.com/creating-a-table-of-contents-generator-in-php/#comment-1513 Nathan Fri, 30 Oct 2009 20:18:08 +0000 http://www.webdesignlessons.com/?p=295#comment-1513 Hi, Thanks for sharing your function! It definitely saved me some time. You've got a few bugs that I came across: - your regex assumes that there won't be any tags within a heading, so having a "strong" tag around a word in your heading, for instance, causes the heading to be missed by the regex - when you start your nested list, you end up with an extra li. The nested ul should be within the li tag of its "parent". If you style your li with bullets you'll see what I'm talking about. - the $Sections array isn't being constructed quite right. do a print_r on it and you'll see what I mean... you just need to remove the $val[2] and add the $val[4] By the way, PLEASE change your wordpress setup so that when you post code, it doesn't kill the indents and transform all the single and double quotation marks! I'd be more explicit with my suggestions above but if I wrote the actual code I'm sure it would get mangled :) Peace, Nathan Hi,

Thanks for sharing your function! It definitely saved me some time.

You’ve got a few bugs that I came across:

- your regex assumes that there won’t be any tags within a heading, so having a “strong” tag around a word in your heading, for instance, causes the heading to be missed by the regex

- when you start your nested list, you end up with an extra li. The nested ul should be within the li tag of its “parent”. If you style your li with bullets you’ll see what I’m talking about.

- the $Sections array isn’t being constructed quite right. do a print_r on it and you’ll see what I mean… you just need to remove the $val[2] and add the $val[4]

By the way, PLEASE change your wordpress setup so that when you post code, it doesn’t kill the indents and transform all the single and double quotation marks! I’d be more explicit with my suggestions above but if I wrote the actual code I’m sure it would get mangled :)

Peace,
Nathan

]]>